This repository was archived by the owner on Jan 24, 2018. It is now read-only.
Fix _smoothScrolling state at animateTo animation end#454
Open
ewanm89 wants to merge 3 commits intoPrinzhorn:masterfrom
Open
Fix _smoothScrolling state at animateTo animation end#454ewanm89 wants to merge 3 commits intoPrinzhorn:masterfrom
ewanm89 wants to merge 3 commits intoPrinzhorn:masterfrom
Conversation
Update the state of _smoothScrolling state when animateTo animation ends so that the smooth scroll doesn't trigger on the next render loop.
Apparently the _instance.getScrollTop() doesn't always return the right value so switched to renderTop.
merging upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the smooth scroll triggers after the end of the .animateTo() causing a flash as the current scroll point is incorrect in the _smoothScrolling object.